Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert our workaround cursor toggle as this has been fixed in vscode #2720

Merged
merged 3 commits into from
Jun 15, 2018

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Jun 8, 2018

What this PR does / why we need it:

  • Going through the issue history, this was fixed by vscode
  • Tested it for a bit and it does seem to be indeed the case which makes this piece of code redundant

Which issue(s) this PR fixes

Special notes for your reviewer:

@xconverge
Copy link
Member

This happened when switching tabs when 2 tabs were in different modes I believe, just for testing purposes

@jpoon
Copy link
Member Author

jpoon commented Jun 8, 2018

Just tried it out again. Seems to be fine. One tab in INSERT showed |, another tab in NORMAL showed the block cursor.

@TravisBuddy
Copy link

Hey @jpoon,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

1 similar comment
@TravisBuddy
Copy link

Hey @jpoon,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

@jpoon jpoon merged commit 4d365e5 into master Jun 15, 2018
@jpoon jpoon deleted the revert-cursor-toggle branch June 15, 2018 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants