feat: log to outputChannel #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xconverge
reviewed
May 7, 2018
|
|
||
| // Handle scenarios where mouse used to change current position. | ||
| const disposable = vscode.window.onDidChangeTextEditorSelection(e => { | ||
| if (configuration.disableExt) { | ||
| return; | ||
| } | ||
|
|
||
| if (Globals.isTesting) { |
There was a problem hiding this comment.
Why do you think this is better here instead of in the actual handler?
Do you know that the handler was only called from here?
There was a problem hiding this comment.
Tbh, I moved it because I didn't see a reason for it to be in the actual handler. This is the only spot the handler is being called from and to save us from queuing something onto our task queue only to exit shortly thereafter seemed wasteful.
There was a problem hiding this comment.
ok, we just don't test this function at all so it terrifies me
|
This is really cool though! |
jpoon
force-pushed
the
log
branch
2 times, most recently
from
46229bf to
feec55b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes
Special notes for your reviewer: