fix: clean-up neovim processes. closes #2038 #2395
Conversation
jpoon
force-pushed
the
neovim-clean-up
branch
from
37d310f to
b65e4a9
Compare
| } else { | ||
| await cmd.execute(vimState.editor, vimState); | ||
| } | ||
| } catch (e) { | ||
| if (e instanceof VimError) { | ||
| if (e.code === ErrorCode.E492 && configuration.enableNeovim) { | ||
| await Neovim.command(vimState, command); | ||
| await vimState.nvim.run(vimState, command); |
There was a problem hiding this comment.
@Chillee, I don't quite understand this bit. Why are we retrying with neovim again?
There was a problem hiding this comment.
When we pass the command into our own command line command/parser, there's lots of cases in which the parser will error (since it doesn't support a lot of commands).
If the parser can't parse it, then we try sending it to the neovim parser (which may support the command).
There was a problem hiding this comment.
So basically, the above code that detects if the command is neovim capable and passes it to Neovim only works for commands that we know are neovim capable. There's lots of commands that we don't implement, and the parser errors out in those cases.
jpoon
force-pushed
the
neovim-clean-up
branch
from
b65e4a9 to
078c2bf
Compare
|
just want to say that v11.0 has restored neo-vim functionality for me. Neo-vim features were broken for me in 10.13 but this patch seems to have fixed it. Thanks! |
What this PR does / why we need it: Properly kills neovim processes on exit. Refactoring of neovim to a class.
Which issue(s) this PR fixes #2038
Special notes for your reviewer: