Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(2145): reverse logic #2147

Merged
merged 2 commits into from
Nov 14, 2017
Merged

fix(2145): reverse logic #2147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a32ec4b
fix(2145): reverse logic
jpoon Nov 14, 2017
94c34b3
update(changelog) for v0.10.4
jpoon Nov 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
# [v0.10.4 Unjust Umbrella](https://github.com/VSCodeVim/Vim/releases/tag/v0.10.4) (Nov 14, 2017)

Patch release that fixes issue with <code>handleKeys</code> settings (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="273862731" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/2145" href="https://github.com/VSCodeVim/Vim/issues/2145">#2145</a>)
# [v0.10.3 Quirky Quorum](https://github.com/VSCodeVim/Vim/releases/tag/v0.10.3) (Nov 13, 2017)
* Implementation of <code>U</code> command (Thanks <a class="user-mention" href="https://github.com/westim">@westim</a>)
* Fix <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="236737059" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/1852" href="https://github.com/VSCodeVim/Vim/issues/1852">#1852</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="264592194" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/2063" href="https://github.com/VSCodeVim/Vim/issues/2063">#2063</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="266658890" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/2080" href="https://github.com/VSCodeVim/Vim/issues/2080">#2080</a> (Thanks <a class="user-mention" href="https://github.com/strafos">@Strafos</a> )

Collection of features and bug fixes mainly from the community! Thanks <a class="user-mention" href="https://github.com/westim">@westim</a>, <a class="user-mention" href="https://github.com/strafos">@Strafos</a>, <a class="user-mention" href="https://github.com/daneestar">@DanEEStar</a>, <a class="user-mention" href="https://github.com/oliver-newman">@oliver-newman</a>, <a class="user-mention" href="https://github.com/parkovski">@parkovski</a>, <a class="user-mention" href="https://github.com/ohjames">@ohjames</a>, <a class="user-mention" href="https://github.com/westim">@westim</a>.
* Implementation of U command (Thanks <a class="user-mention" href="https://github.com/westim">@westim</a>)
* Fix <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="236737059" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/1852" href="https://github.com/VSCodeVim/Vim/issues/1852">#1852</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="264592194" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/2063" href="https://github.com/VSCodeVim/Vim/issues/2063">#2063</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="266658890" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/2080" href="https://github.com/VSCodeVim/Vim/issues/2080">#2080</a> (Thanks <a class="user-mention" href="https://github.com/strafos">@Strafos</a> )
* Fix <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="238988658" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/1877" href="https://github.com/VSCodeVim/Vim/issues/1877">#1877</a> (Thanks <a class="user-mention" href="https://github.com/daneestar">@DanEEStar</a>)
* Fix <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="231841700" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/1772" href="https://github.com/VSCodeVim/Vim/issues/1772">#1772</a> - gj/gk in Visual Mode (Thanks <a class="user-mention" href="https://github.com/oliver-newman">@oliver-newman</a> )
* Fix multiline search and case sensitivity override <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="267777671" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/2086" href="https://github.com/VSCodeVim/Vim/issues/2086">#2086</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="269266372" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/2101" href="https://github.com/VSCodeVim/Vim/issues/2101">#2101</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="269202916" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/2100" href="https://github.com/VSCodeVim/Vim/issues/2100">#2100</a> - (Thanks <a class="user-mention" href="https://github.com/parkovski">@parkovski</a> )
* Fix remappings of <code>u</code>, <code>C</code>, <code>gl</code> <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="271211276" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/2116" href="https://github.com/VSCodeVim/Vim/issues/2116">#2116</a> (Thanks <a class="user-mention" href="https://github.com/ohjames">@ohjames</a> )
* Fix multiline search and case sensitivity override <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="267777671" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/2086" href="https://github.com/VSCodeVim/Vim/issues/2086">#2086</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="269266372" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/2101" href="https://github.com/VSCodeVim/Vim/issues/2101">#2101</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="269202916" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/2100" href="https://github.com/VSCodeVim/Vim/issues/2100">#2100</a> - (Thanks <a class="user-mention" href="https://github.com/parkovski">@parkovski</a>)
* Fix remappings of u, C, gl <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="271211276" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/2116" href="https://github.com/VSCodeVim/Vim/issues/2116">#2116</a> (Thanks <a class="user-mention" href="https://github.com/ohjames">@ohjames</a> )
* Add ability to toggle vim mode in extension <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="270984061" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/2113" href="https://github.com/VSCodeVim/Vim/issues/2113">#2113</a> (Thanks <a class="user-mention" href="https://github.com/westim">@westim</a>)
* Fix <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="224659577" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/1586" href="https://github.com/VSCodeVim/Vim/issues/1586">#1586</a> (<a class="user-mention" href="https://github.com/jpoon">@jpoon</a>)
* Fix <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="224659577" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/1586" href="https://github.com/VSCodeVim/Vim/issues/1586">#1586</a>. Code-cleanup and optimizations with retrieving configurations (<a class="user-mention" href="https://github.com/jpoon">@jpoon</a>)
# [v0.10.2 Pesky Penguin](https://github.com/VSCodeVim/Vim/releases/tag/v0.10.2) (Oct 14, 2017)
* g; and g, index fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="235039316" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/1824" href="https://github.com/VSCodeVim/Vim/issues/1824">#1824</a> <a class="user-mention" href="https://github.com/westim">@westim</a>
* visual selection fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="237705862" data-permission-text="Issue title is private" data-url="https://github.com/VSCodeVim/Vim/issues/1860" href="https://github.com/VSCodeVim/Vim/issues/1860">#1860</a> <a class="user-mention" href="https://github.com/westim">@westim</a>
Expand Down
2 changes: 1 addition & 1 deletion src/configuration/configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class ConfigurationClass {
// By default, all key combinations are used
let useKey = true;

if (this.handleKeys[bracketedKey]) {
if (this.handleKeys[bracketedKey] === false) {
// disabled through `vim.handleKeys`
useKey = false;
} else if (!this.useCtrlKeys && bracketedKey.slice(1, 3) === 'C-') {
Expand Down