-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for copy and p command #208
Support for copy and p command #208
Conversation
I think this may fix the build failures connected to VSCodeVim#208
The build stage seems to be fixed but there is still a problem with some of the unit tests falling over. The error |
I was able to craft an update to the Travis CI config that fixes the problem. Here is the commit. |
@petegleeson , is there a way in which you can merge @edthedev change (#211) into your own PR? |
My initial fork was from this branch, so unless I'm mistaken, @petegleeson's commits are included. I intended to make my pull request back to his copy for #209, but I could not figure out how. I think I pressed the fork button one too many times in the GitHub web interface. |
I'll be happy to submit a corrected pull if someone can direct me how. Couldn't find the thing when U tried, but it was kind late. I might have missed something obvious. |
Huh. @peteglessons commits are not part of #211. I think I can merge, then submit a new pull. |
I did some comparison and found that @petegleeson's solution to the travis.yml file was superior to mine anyway. I have closed #211 as it adds nothing that is not already here. |
Latest commit on this branch passes in Travis for me. |
Well the travis builds has gone green without any code changes... @edthedev with the magic touch. If you guys are happy with these changes I would love to get this merged 😄 |
Looks good. I closed #212 as duplicate. I'm not sure if Travis CI getting happy is related to poking it again, or if the timing is just coincidence. Either way, I'm glad that Travis CI agrees that this looks good to go, though. :) |
@petegleeson, @edthedev: Thanks guys. Also pushed out a new release. |
Weird, the master branch builds are now broken :| |
Changing sudo: false to sudo: true in .travis.yml will probably did the problem. I'm guessing Travis CI changes their rules based on usage frequency thus the tests fail on the main repo after passing in the micro forks. |
I would fork and test my theory, except that I will probably continue to get a passing build in my fork, anyway. If I can find anything in the Travis docs that could shed done light, I'll report that info back here. |
Hello, I have added two things:
When first looking around I found this issue on the vscode repository about supporting copy/paste operations for extensions. I have followed the advice in that issue and included the copy-paste npm package to do copy/paste.
Be great to hear what everyone thinks 👍