Easymotion new features #1967
Easymotion new features #1967
Conversation
|
Awesome! Seems like this incorporates your previous PR in it as well, right? |
|
I'm going to update this branch because I fixed some issues with flaky tests on master. |
|
Yes, I think it is ok to merge only this one or merge the previous one first, and then this one. |
|
Unfortunately, ci-test seemed to fail. I will investigate the reason. |
maxfie1d
force-pushed
the
easymotion-new-features
branch
from
37758cc to
03e9178
Compare
|
I think you're good. The first 5 tests seem to be failing on master for w.e. reason as well. |
maxfie1d
force-pushed
the
easymotion-new-features
branch
from
8365b92 to
5ba6ac4
Compare
|
So to confirm, this is A-OK to merge? |
|
Yes! |
|
Thank you for your great work! Could you just explain the thing brought up in the code review? |
|
You mean I explain what is changed with this PR in the code review area on GitHub?
|
|
@MaxfieldWalker Just specifically, what is I don't see it on the easymotion github readme. |
|
The difference between 's' and '2s' is characters used for search. Like the GIF below,
|
|
@MaxfieldWalker Is this a standard vim-easymotion feature? |
|
[Edited] Two-character search motion is explained here. By default, two-character move motions are not mapped (default mappings are defined here). I thought it is always required to assign some keymap to some command for this extension, but is it OK not to do so? |
README.md
Outdated
| `<leader> <leader> b`|Start of word backwards | ||
| `<leader> <leader> e`|End of word forwards | ||
| `<leader> <leader> g e`|End of word backwards | ||
| `<leader><leader> s <char>` or `<leader><leader> 2s <char><char>`|Search character |
There was a problem hiding this comment.
Sorry, I'm not familiar with the 2. What's the purpose of that? If it's supposed to show that it support a count, then I think the convention is <count>.
There was a problem hiding this comment.
At present, count is not supported. '2' means just requiring two characters for search.
Original easymotion plugin seems not to support <count> for this kind of motions.
| `<leader><leader> ge`|End of word backwards | ||
| `<leader><leader> j`|Start of line forwards | ||
| `<leader><leader> k`|Start of line backwards | ||
| `<leader><leader> / <char>... <CR>`|Search n-character |
|
@MaxfieldWalker Yep our command system isn't expressive enough to express "unmapped" commands. I was just wondering if there was a "semi-standard" mapping for those commands. Could you also explain them in the README? |
|
@Chillee I see. |
|
Thanks for the great work! |
|
ah damn I wasn't trying to squash and merge... |
This PR includes some new features and improvements of easymotion.
New Features
<leader><leader>/<character>...<leader><leader>2s<character><character>Improvements
This PR is a continuation of my previous PR #1932.