-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1941: Action repetition with Ctrl-[ #1953
Fixes #1941: Action repetition with Ctrl-[ #1953
Conversation
@tagniam Thanks! I swear I'll fix the Travis issue soon(TM), and then I can merge a bunch of PR's :( |
@tagniam Could you add a test covering this case? Ask if you need any help with doing tests. |
@Chillee Sure! I haven't written any tests with typescript before, is there anything you're looking for in particular? |
@tagniam Just take a look at the other tests in the tests folder. I'd probably put it in modeNormal.test.ts |
As for what the tests should cover, the test should break before you fixed this issue, and pass after you've fixed the issue. So, for example, |
@Chillee Thanks, I'm in the middle of exams right now but I'll get to writing the tests for both my PRs as soon as I can :) |
@tagniam Good luck with your exams! I started working on VsCodeVim purely while I was procrastinating on exams :) |
@Chillee Well it looks like I need to procrastinate more often then. :) Thanks! |
@Chillee done! |
Thanks for the contribution! |
Ctrl-[
is already defined as a synonym forEsc
inCommandEsc
. RemovingCommandCtrlOpenBracket
fixes the action repetition problem. I think it was code leftover from before a refactor.Fixes #1941