gUU and guu #1428
gUU and guu #1428
Conversation
src/actions/actions.ts
Outdated
| @@ -2082,7 +2082,7 @@ export class UpperCaseOperator extends BaseOperator { | |||
| await TextEditor.replace(range, text.toUpperCase()); | |||
|
|
|||
| vimState.currentMode = ModeName.Normal; | |||
| vimState.cursorPosition = start; | |||
| vimState.cursorPosition = vimState.cursorPositionJustBeforeAnythingHappened[0]; | |||
There was a problem hiding this comment.
Why is this necessary over using start? (Also the [0] won't be multi cursor friendly like start and end are)
There was a problem hiding this comment.
this entire command is already not multicursor friendly though (bad reason I know)
start in the case of gUU is start of line and end is end of line
gUU is not supposed to move the cursor so it needs to perform the action and remain in place
There was a problem hiding this comment.
gUU looks like it just moves the cursor to the beginning of the line or am I wrong?
There was a problem hiding this comment.
you are right...I am so confused, I wonder if it does the same thing in gvim, I tried yesterday...I will change to start, thats easy
src/actions/actions.ts
Outdated
| @@ -5132,6 +5133,32 @@ class MoveFormat extends BaseMovement { | |||
| } | |||
|
|
|||
| @RegisterAction | |||
| class MoveUpercaseLine extends BaseMovement { | |||
There was a problem hiding this comment.
Can you leave a comment here saying that these are for guu and gUU (for searchability mostly)
| @@ -5131,6 +5132,34 @@ class MoveFormat extends BaseMovement { | |||
| } | |||
| } | |||
|
|
|||
| // Used for gUU | |||
There was a problem hiding this comment.
It'd probably be good to move these next to the other weirdo motions I made for dd yy cc etc.
There was a problem hiding this comment.
oh, nice! i didn't hit that little fold out button enough.
There was a problem hiding this comment.
yea I think the > and = are also of the same weirdo type
fixes #1423