Allowing user to selectively disable some key combos #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey combinations with a config option
xconverge
commented
Mar 25, 2017
package.json
Outdated
| }, | ||
| { | ||
| "key": "ctrl+p", | ||
| "command": "extension.vim_ctrl+p", | ||
| "when": "suggestWidgetVisible && vim.useCtrlKeys" | ||
| "when": "suggestWidgetVisible && vim.use<C-p> vim.useCtrlKeys" |
package.json
Outdated
| }, | ||
| { | ||
| "key": "ctrl+n", | ||
| "command": "extension.vim_ctrl+n", | ||
| "when": "suggestWidgetVisible && vim.useCtrlKeys" | ||
| "when": "suggestWidgetVisible && vim.use<C-n> vim.useCtrlKeys" |
…ted when you update config without needing to restart
…guration for reference
xconverge
changed the title
Closed
|
This LGTM. It's really interesting that properties in package.json can include < and > characters. |
|
Yea that felt a bit crazy, but if it works it works. I figured it wasn't any worse than vim.useCtrl+k etc, and then atleast the nomenclature is the same throughout our remappings etc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like this. PR for #1424
example config option that may be handy on windows for some
I would like to have it all in configuration.ts so that it can happen without a vscode restart so that will be next. Then trying to clean it up some more and make sure all of our keys in package.json are handled (only modifier key combos I think will be part of this)