Fix #1329 failing build by removing undefined in configuration.ts #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for updating to the latest typescript version! |
|
Uh, github won't let me merge in mobile. I'll try again later. |
|
No problem. Glad i could be of help :) |
|
Hmm...It seems that one of the test failed after merging master into my forked repo, but when i tried the test myself after pulling, there was no problem. Can someone with write access try to rebuild with travis and see if the test still fails? |
|
you should be good, that is a flakey test |
|
I see. Thanks for checking:) I was worried I might have broken the test since its my first PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1329
The reason behind failing build was due to the changes made in typescript 2.2 as below.
Hence, I removed union type of undefined in configuration.ts to make the build work.
Builds successfully in typescript 2.1.6 & 2.2.1