Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<C-o> not working on sneak search #4696

Closed
luisherranz opened this issue Mar 29, 2020 · 2 comments · Fixed by #4697
Closed

<C-o> not working on sneak search #4696

luisherranz opened this issue Mar 29, 2020 · 2 comments · Fixed by #4697

Comments

@luisherranz
Copy link
Contributor

luisherranz commented Mar 29, 2020 •
edited
Loading

Describe the bug
When you do a search with vim-sneak, VSCodeVim doesn't save your position and you can't go back to where you were before using <C-o>.

To Reproduce
Steps to reproduce the behavior:

  1. Activate vim-sneak.
  2. Do a forward seach with s<char><char>.
  3. Try to go back to where you were before the search using <C-o>.
  4. It doesn't go back :(

Expected behavior
In normal vim/nvim you can do a search and get back to where you were using <C-o>. This is quite common when you need to write a long word which exists somewhere else:

  • Jump to that word using sneak.
  • Yank it.
  • Go back to where you were with <C-o>
  • Paste the word and continue writing.

Screenshots

Doesn't work on VSCodeVim
ezgif com-video-to-gif

But works perfectly on Vim/Nvim
ezgif com-video-to-gif (1)

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.13.1
  • VSCode version: 1.43.2
  • OS: macOS Catalina
@luisherranz luisherranz changed the title <C-o> not working on sneak <C-o> not working on sneak or easymotion Mar 29, 2020
@luisherranz luisherranz changed the title <C-o> not working on sneak or easymotion <C-o> not working on sneak or easymotion jump Mar 29, 2020
@luisherranz
Copy link
Contributor Author

BTW, I'm willing to do a PR is someone points me out to the function that is used to save the position for the <C-o> command.

@luisherranz luisherranz changed the title <C-o> not working on sneak or easymotion jump <C-o> not working on sneak search Mar 29, 2020
luisherranz added a commit to luisherranz/Vim that referenced this issue Mar 29, 2020
@luisherranz
Add isJump to sneak movements (VSCodeVim#4696)
139af3c 
When you do a search with vim-sneak, VSCodeVim doesn't save your
position and you can't go back to where you were before using <C-o>.
This PR adds isJump to both sneak movements.

Fixes VSCodeVim#4696
@luisherranz luisherranz mentioned this issue Mar 29, 2020
Merged
@luisherranz
Copy link
Contributor Author

Well, it was not hard so I did it myself: #4697 🙂

@gergelyth gergelyth mentioned this issue Apr 3, 2020
Closed
J-Fields pushed a commit that referenced this issue Apr 24, 2020
@luisherranz
Add isJump to sneak actions (#4697)
e02453a 
When you do a search with vim-sneak, VSCodeVim doesn't save your
position and you can't go back to where you were before using .

This PR adds isJump to both sneak movements to fix that.

Fixes #4696.
berknam pushed a commit to berknam/Vim that referenced this issue May 5, 2020
@luisherranz @berknam
Add isJump to sneak actions (VSCodeVim#4697)
63047ce 
When you do a search with vim-sneak, VSCodeVim doesn't save your
position and you can't go back to where you were before using .

This PR adds isJump to both sneak movements to fix that.

Fixes VSCodeVim#4696.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add isJump to sneak actions luisherranz/Vim
Sneak highlighting
1 participant
@luisherranz