Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with visual line select mode and 'gj' #1377

Closed
ursuscamp opened this issue Mar 10, 2017 · 3 comments
Closed

Issue with visual line select mode and 'gj' #1377

ursuscamp opened this issue Mar 10, 2017 · 3 comments

Comments

@ursuscamp
Copy link
Contributor

ursuscamp commented Mar 10, 2017

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.


What did you do?

  1. Enter visual line selection mode: V
  2. Use gj to move between wrapped lines.

What did you expect to happen?

The selection to extend as many lines as required.

What happened instead?

The selection doesn't extend past three lines.

example gif of bug

Technical details:

  • VSCode Version: 1.10.2
  • VsCodeVim Version: 0.6.2
  • OS: macOS Sierra
@johnfn
Copy link
Member

johnfn commented Mar 22, 2017

As a temporary solution, you can remap j to gjo rather than just gj. 😉 But I think @xconverge has a better solution coming soon.

@xconverge
Copy link
Member

related microsoft/vscode#23045

I should be able to work through this with what we have so far right now though, but it might not be pretty

@xconverge
Copy link
Member

Also we need to make sure the when we expand and shrink the selection, it works similar to how V with j and k work.

Currently, it seems like if you do V then gk gk gk gk, when you do gj, it will expand from the bottom, instead of shrinking the selection by 1 line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants