-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libsndfile-binariesと依存ライブラリのライセンスを追加 #192
Merged
Hiroshiba
merged 70 commits into
VOICEVOX:master
from
HyodaKazuaki:add-libsndfile-depnd-lib-license
Nov 18, 2021
Merged
libsndfile-binariesと依存ライブラリのライセンスを追加 #192
Hiroshiba
merged 70 commits into
VOICEVOX:master
from
HyodaKazuaki:add-libsndfile-depnd-lib-license
Nov 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependencies library licenses
Hiroshiba
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
助かります、ありがとうございます!!
Linuxにライブラリが書かれてしまいますが、そのライブラリを借りて開発しているのはまあ事実なので、一旦そのままで良いかなと思いました。
y-chan
pushed a commit
to y-chan/voicevox_engine
that referenced
this pull request
Nov 23, 2021
* add macos autobuild * add cmake * fix variable settings * add PyOpenJTalk dictionary download * add download and build directory creation * fix LD_LIBRARY_PATH setting * fix env variable * fix variable specification * fix LD_LIBRARY_PATH setting * fix name * add gcc installation * fix core path * add workaround for scipy installation * split numpy and scipy install command * fix typo * revert workaround scipy installation * add OPENBLAS env variable * add llvm installation * remove gcc and llvm installation * add gfortran installation * add gcc 11 selection * add debug action * add GFortran alias * change GFortran alias timing * add GFortran path * add fortran environment variable * change CC and FC environment variable * add BASE_PATH environment variable * add VOICEVOX_CORE_DIR environment variable * fix venv path * fix upload path * add SoundFile package data * fix cache process miss * disable voicevox core cache * disable voicevox core example cache * add libsnd * fix include path * fix environment variable * fix include data file path * add execute permission and compressing action * update build directory * remove mkdir process * change upload file * add cache * change to relative path * add execute persmission process * fix change owner process * remove changer owner and add exclude option * change key * fix venv activation * cache test * add mac build to upload to release * remove libtorch path from LD_LIBRARY_PATH * remove dependency on OpenBLAS * disable cache * add LibTorch / CCache installation process * fix venv path * delete cache * fix syntax * fix cache clean * revert cache clear * fix venv specification path * remove build_voicevox venv * fix library path * add python cache * fix include data file path * add libsndfile-binraries and dependencies library licenses * ignore line too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Windows/Mac向けビルドに同梱されているlibsndfile-binaries及びそれに静的リンクされたライブラリのライセンスを追加します。
ライブラリ
関連 Issue
close #187
ref #106
スクリーンショット・動画など
なし
議論
このPRでは、すべてのビルドターゲットに対して同じライセンスを生成します。
これにより、このPRが対象とするライブラリを同梱していないLinux向けビルドでも、同様にライセンスが表示されます。
この点は回避すべきでしょうか?
なお、これは
generate_licenses.py
の該当箇所でプラットフォーム判定をすることで処理することができます。