Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsndfile-binariesと依存ライブラリのライセンスを追加 #192

Merged
merged 70 commits into from
Nov 18, 2021
Merged

libsndfile-binariesと依存ライブラリのライセンスを追加 #192

merged 70 commits into from
Nov 18, 2021

Conversation

HyodaKazuaki
Copy link
Contributor

内容

Windows/Mac向けビルドに同梱されているlibsndfile-binaries及びそれに静的リンクされたライブラリのライセンスを追加します。

ライブラリ

  • libsndfile
  • libogg
  • libverbis
  • libflac

関連 Issue

close #187
ref #106

スクリーンショット・動画など

なし

議論

このPRでは、すべてのビルドターゲットに対して同じライセンスを生成します。
これにより、このPRが対象とするライブラリを同梱していないLinux向けビルドでも、同様にライセンスが表示されます。
この点は回避すべきでしょうか?
なお、これはgenerate_licenses.pyの該当箇所でプラットフォーム判定をすることで処理することができます。

    # libsndfile-binaries
    if sys.platform == "win32" or sys.platform == "darwin":
        with urllib.request.urlopen(
            "https://raw.githubusercontent.com/bastibe/libsndfile-binaries/84cb164928f17c7ca0c1e5c40342c20ce2b90e8c/COPYING"
        ) as res:
            licenses.append(
                License(
                    name="libsndfile-binaries",
                    version="1.0.28",
                    license="LGPL-2.1 license",
                    text=res.read().decode(),
                )
            )

@github-actions
Copy link

Coverage Result

Resultを開く
Name Stmts Miss Cover
run.py 255 190 coverage-25%
voicevox_engine/acoustic_feature_extractor.py 81 0 coverage-100%
voicevox_engine/cancellable_engine.py 78 59 coverage-24%
voicevox_engine/full_context_label.py 145 7 coverage-95%
voicevox_engine/kana_parser.py 75 1 coverage-99%
voicevox_engine/model.py 81 7 coverage-91%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/synthesis_engine.py 128 18 coverage-86%
TOTAL 847 282 coverage-67%

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
助かります、ありがとうございます!!

Linuxにライブラリが書かれてしまいますが、そのライブラリを借りて開発しているのはまあ事実なので、一旦そのままで良いかなと思いました。

@Hiroshiba Hiroshiba merged commit 0ecbb16 into VOICEVOX:master Nov 18, 2021
@HyodaKazuaki HyodaKazuaki deleted the add-libsndfile-depnd-lib-license branch November 18, 2021 16:09
y-chan pushed a commit to y-chan/voicevox_engine that referenced this pull request Nov 23, 2021
* add macos autobuild

* add cmake

* fix variable settings

* add PyOpenJTalk dictionary download

* add download and build directory creation

* fix LD_LIBRARY_PATH setting

* fix env variable

* fix variable specification

* fix LD_LIBRARY_PATH setting

* fix name

* add gcc installation

* fix core path

* add workaround for scipy installation

* split numpy and scipy install command

* fix typo

* revert workaround scipy installation

* add OPENBLAS env variable

* add llvm installation

* remove gcc and llvm installation

* add gfortran installation

* add gcc 11 selection

* add debug action

* add GFortran alias

* change GFortran alias timing

* add GFortran path

* add fortran environment variable

* change CC and FC environment variable

* add BASE_PATH environment variable

* add VOICEVOX_CORE_DIR environment variable

* fix venv path

* fix upload path

* add SoundFile package data

* fix cache process miss

* disable voicevox core cache

* disable voicevox core example cache

* add libsnd

* fix include path

* fix environment variable

* fix include data file path

* add execute permission and compressing action

* update build directory

* remove mkdir process

* change upload file

* add cache

* change to relative path

* add execute persmission process

* fix change owner process

* remove changer owner and add exclude option

* change key

* fix venv activation

* cache test

* add mac build to upload to release

* remove libtorch path from LD_LIBRARY_PATH

* remove dependency on OpenBLAS

* disable cache

* add LibTorch / CCache installation process

* fix venv path

* delete cache

* fix syntax

* fix cache clean

* revert cache clear

* fix venv specification path

* remove build_voicevox venv

* fix library path

* add python cache

* fix include data file path

* add libsndfile-binraries and
dependencies library licenses

* ignore line too long
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

soundfileが同梱しているbastibe/libsndfile-binariesのライセンス記載が無い
2 participants