-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Linux: VOICEVOX CORE 0.6.0に追従 #114
Merged
Hiroshiba
merged 23 commits into
VOICEVOX:master
from
aoirint:patch-linux-voicevox-core-0.6.0
Sep 23, 2021
Merged
Docker Linux: VOICEVOX CORE 0.6.0に追従 #114
Hiroshiba
merged 23 commits into
VOICEVOX:master
from
aoirint:patch-linux-voicevox-core-0.6.0
Sep 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Sep 21, 2021
This was referenced Sep 21, 2021
Hiroshiba
reviewed
Sep 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一箇所だけ気になったのでコメントしました!
Hiroshiba
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hiroshiba
pushed a commit
that referenced
this pull request
Sep 23, 2021
* docker: add BASE_IMAGE arg * build-docker: support BASE_IMAGE arg * build-docker: add ubuntu18.04 images * fix duplicated docker image tags * Makefile: build-linux-docker-ubuntu18.04 * linux: sort workflow job matrix * linux docker: upgrade to VOICEVOX CORE 0.6.0 * linux docker: overwrite gpu so with cpu so * linux docker: rewrite setup.py to use libcore_cpu for cpu image * remove unused core shared object (prevent ldconfig error) * swap build arg order (core library name -> core example version) * revert swap * fix yaml string * fix yaml string * fix matrix * fix matrix * reduce diff * revert matrix build.yml * on push master * split workaround layer * follow voicevox core 0.6.0 * Makefile: follow #114 * reset workaround: rename libcore_cpu to libcore * rm -f instead rm * reorder entrypoint.sh dump to fast debug rebuild * logic to determine old glibc is used or not * replace glibc version check logic with build arg flag * add use_glibc_229_workaround build-arg to workflow * workflow: commonize voicevox_core_version, voicevox_core_example_version * add os in matrix * add tag to matrix * commonize os * fix matrix for build.yml * fix matrix for build.yml * rm os in include * add tag in matrix * use cpu core for cpu-ubuntu18.04 * rename GLIBC_229_WORKAROUND to GLIBC_231_WORKAROUND * fix indent * remove redundant versions * replace retry logic (unsupported feature for old gnu parallel) * fix indent * revert ldconfig location
Hiroshiba
pushed a commit
that referenced
this pull request
Sep 23, 2021
* docker: add BASE_IMAGE arg * build-docker: support BASE_IMAGE arg * build-docker: add ubuntu18.04 images * fix duplicated docker image tags * Makefile: build-linux-docker-ubuntu18.04 * linux: sort workflow job matrix * linux docker: upgrade to VOICEVOX CORE 0.6.0 * linux docker: overwrite gpu so with cpu so * linux docker: rewrite setup.py to use libcore_cpu for cpu image * remove unused core shared object (prevent ldconfig error) * swap build arg order (core library name -> core example version) * revert swap * fix yaml string * fix yaml string * fix matrix * fix matrix * reduce diff * revert matrix build.yml * on push master * split workaround layer * follow voicevox core 0.6.0 * Makefile: follow #114 * reset workaround: rename libcore_cpu to libcore * rm -f instead rm * reorder entrypoint.sh dump to fast debug rebuild * logic to determine old glibc is used or not * replace glibc version check logic with build arg flag * add use_glibc_229_workaround build-arg to workflow * workflow: commonize voicevox_core_version, voicevox_core_example_version * add os in matrix * add tag to matrix * commonize os * fix matrix for build.yml * fix matrix for build.yml * rm os in include * add tag in matrix * use cpu core for cpu-ubuntu18.04 * rename GLIBC_229_WORKAROUND to GLIBC_231_WORKAROUND * fix indent * remove redundant versions * replace retry logic (unsupported feature for old gnu parallel) * fix indent * revert ldconfig location * build linux build on ubuntu 18.04 * change nuitka cache key to use tag * Makefile: download env target * use pre-cxx11 abi libtorch for ubuntu 18.04 * use pre-cxx11 abi libtorch for ubuntu 18.04 * revert to cxx11-abi * rm ld.so.conf.d/libtorch.conf for GLIBC_231_WORKAROUND * add --show-progress for nuitka build * Makefile: binary build on ubuntu 18.04 * rm show progress * use glibc 231 flag for binary build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INFERENCE_DEVICE
を廃止(複数の目的に使われないようにするため)VOICEVOX_CORE_LIBRARY_NAME
を追加(core_cpu
またはcore
)libcore_cpu.so
)を使用VOICEVOX_CORE_LIBRARY_NAME
libcore_cpu.so
、libcore.so
)を使うか選択libcore.so
に統一ldconfig
がCPU・GPUの共有ライブラリを重複したライブラリとして扱い、一方を認識しない問題が起きたため/sbin/ldconfig.real: /opt/voicevox_core/libcore.so is not a symbolic link