/connect_wavesを追加 #109
Merged
/connect_wavesを追加 #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
waveを使っていましたが、既に使用しているモジュールであるpysoundfileを使用するように変更しました。 |
Hiroshiba
requested changes
Sep 24, 2021
run.py
Outdated
| if len(waves) == 0: | ||
| raise HTTPException(status_code=422, detail="wavファイルが含まれていません") | ||
|
|
||
| waves_nparray = [] |
There was a problem hiding this comment.
ここに書くには処理が大きく、テストが書きにくそうなので、関数として切り出し頂けると！
エラーハンドリングが少しややこしいですが、関数内でHTTPExceptionをraiseしてしまっても良いかなと思いました。
There was a problem hiding this comment.
Hiroshiba@357f316 で関数として切り出ししました
Co-authored-by: Hiroshiba <[email protected]>
Hiroshiba
reviewed
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://github.com/Hiroshiba/voicevox/issues/107
概要
複数のwavファイルをbase64エンコードしたもののリストを投げるとそれを一つにしたwavファイルを返す
/connect_wavesを追加します。まだ動作未テストのためDraftです。