Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: [project-sequencer-statemachine] ErasePitchStateを追加 #2487

Conversation

sigprogramming
Copy link
Contributor

内容

ErasePitchStateの追加とIdleStateの変更を行います。

関連 Issue

その他

@sigprogramming sigprogramming requested a review from a team as a code owner January 15, 2025 11:17
@sigprogramming sigprogramming requested review from Hiroshiba and removed request for a team January 15, 2025 11:17
@voicevox-preview-pages
Copy link

voicevox-preview-pages bot commented Jan 15, 2025

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:d90a48c

@Hiroshiba Hiroshiba requested a review from Copilot January 15, 2025 16:29

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (8)

src/sing/stateMachine/sequencerStateMachine.ts:1178

  • The error message 'innerContext is undefined.' could be more descriptive. Consider including the method name for better context, e.g., 'ErasePitchState.previewErasePitch: innerContext is undefined.'
throw new Error("innerContext is undefined.");

src/sing/stateMachine/sequencerStateMachine.ts:1181

  • The error message 'previewPitchEdit.value is undefined.' could be more descriptive. Consider including the method name for better context, e.g., 'ErasePitchState.previewErasePitch: previewPitchEdit.value is undefined.'
throw new Error("previewPitchEdit.value is undefined.");

src/sing/stateMachine/sequencerStateMachine.ts:1184

  • The error message 'previewPitchEdit.value.type is not erase.' could be more descriptive. Consider including the method name for better context, e.g., 'ErasePitchState.previewErasePitch: previewPitchEdit.value.type is not erase.'
throw new Error("previewPitchEdit.value.type is not erase.");

src/sing/stateMachine/sequencerStateMachine.ts:1215

  • The error message 'innerContext is undefined.' could be more descriptive. Consider including the method name for better context, e.g., 'ErasePitchState.onEnter: innerContext is undefined.'
throw new Error("innerContext is undefined.");

src/sing/stateMachine/sequencerStateMachine.ts:1241

  • The error message 'innerContext is undefined.' could be more descriptive. Consider including the method name for better context, e.g., 'ErasePitchState.process: innerContext is undefined.'
throw new Error("innerContext is undefined.");

src/sing/stateMachine/sequencerStateMachine.ts:1258

  • The error message 'innerContext is undefined.' could be more descriptive. Consider including the method name for better context, e.g., 'ErasePitchState.onExit: innerContext is undefined.'
throw new Error("innerContext is undefined.");

src/sing/stateMachine/sequencerStateMachine.ts:1261

  • The error message 'previewPitchEdit is undefined.' could be more descriptive. Consider including the method name for better context, e.g., 'ErasePitchState.onExit: previewPitchEdit is undefined.'
throw new Error("previewPitchEdit is undefined.");

src/sing/stateMachine/sequencerStateMachine.ts:1264

  • The error message 'previewPitchEdit.type is not erase.' could be more descriptive. Consider including the method name for better context, e.g., 'ErasePitchState.onExit: previewPitchEdit.type is not erase.'
throw new Error("previewPitchEdit.type is not erase.");
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです!!

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

もしかしてそろそろステートマシン完成が近い感じですかね・・・!!
楽しみ!!

@Hiroshiba Hiroshiba merged commit 3007396 into VOICEVOX:project-sequencer-statemachine Jan 16, 2025
10 checks passed
@sigprogramming sigprogramming deleted the add_erase_pitch_state branch January 18, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants