Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vitestのブラウザモードを使えるようにし、StorybookのVitest統合を使う #2289

Merged
merged 39 commits into from
Oct 13, 2024

Conversation

sevenc-nanashi
Copy link
Member

内容

StorybookのVitest統合を使う用にします。

関連 Issue

(なし)

スクリーンショット・動画など

image

その他

(なし)

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner October 9, 2024 12:33
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team October 9, 2024 12:33
package.json Outdated Show resolved Hide resolved
vitest.workspace.mts Outdated Show resolved Hide resolved
vitest.workspace.mts Outdated Show resolved Hide resolved
package.json Outdated
Comment on lines 32 to 34
"postinstall": "run-s postinstall:packages postinstall:download-scripts",
"postinstall:packages": "patch-package --patch-dir build/patches && electron-builder install-app-deps && playwright install",
"postinstall:download-scripts": "node build/download7z.js && node build/downloadTypos.js",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あまりにも横に長すぎたので分割しました。名前はもっといいのがあると思います。

Comment on lines +21 to +22
const modelValue = ref("a");
return { args, modelValue };
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

エラーを吐いていたのでmodelValueを増やしました。

@sevenc-nanashi sevenc-nanashi marked this pull request as draft October 9, 2024 12:57
@sevenc-nanashi sevenc-nanashi marked this pull request as ready for review October 9, 2024 12:59
.storybook/main.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
vite.config.mts Outdated Show resolved Hide resolved
vitest.workspace.mts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
vitest.workspace.mts Outdated Show resolved Hide resolved
vitest.workspace.mts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです!!!
簡潔なプルリクエストありがとうございます!!!レビューしやすいです!!!

plugins: [
vue(),
quasar({ autoImportComponentCase: "pascal" }),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quasar Vite Plugin周りでエラーを吐いていた雰囲気があったので消しました。store/utility.tsの変更はそれに伴うものです。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

・・・これなんのために必要だったんですかね! 消しちゃって良さそう!

Copy link
Member Author

@sevenc-nanashi sevenc-nanashi Oct 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あの後やっぱり戻しました(警告消すためにQuasarのバージョンを上げようとしていたらプラグインなしで動かなくなった)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほどです!
変な差分が発生しちゃってるのでこっちで戻しちゃいます 🙏

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

おそらくこのPRと関係ないのですが、もしよかったらテストが落ちてるのもついでに直しちゃっていただけると・・・!!!! 🙇

@sevenc-nanashi
Copy link
Member Author

修正しました。

@sevenc-nanashi
Copy link
Member Author

そういえば:storybook/test-runnerとpatch-packageが不要担ったので消しました。いい話。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

apply patch不要になったのめでたい!!

ユニットテストを実行する方法がREADMEで数パターン案内されてて、初学者の人はどれ使えばいいかわからないかもですね。
しばらくtest-ui使ってみて、便利そうだと判断したら「これがオススメ!」的な案内をしても良さそう。

useQuasar見て回った感じ、大半が不要にできそうですねぇ。(ただのコメントです)

package.json Outdated
@@ -116,18 +120,19 @@
"happy-dom": "8.4.2",
"license-checker-rseidelsohn": "4.3.0",
"markdownlint-cli": "0.37.0",
"patch-package": "8.0.0",
"npm-run-all2": "6.2.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

便利だけど、依存増やすほどでもない気がしますねぇ。
ちょっとこっちで削除させていただきます!

plugins: [
vue(),
quasar({ autoImportComponentCase: "pascal" }),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほどです!
変な差分が発生しちゃってるのでこっちで戻しちゃいます 🙏

@Hiroshiba
Copy link
Member

マージします!!! 使っていきたい!!!!

@Hiroshiba Hiroshiba merged commit 1e08956 into VOICEVOX:main Oct 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants