-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vitestのブラウザモードを使えるようにし、StorybookのVitest統合を使う #2289
Conversation
src/components/Dialog/SettingDialog/FileNameTemplateDialog.stories.ts
Outdated
Show resolved
Hide resolved
package.json
Outdated
"postinstall": "run-s postinstall:packages postinstall:download-scripts", | ||
"postinstall:packages": "patch-package --patch-dir build/patches && electron-builder install-app-deps && playwright install", | ||
"postinstall:download-scripts": "node build/download7z.js && node build/downloadTypos.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あまりにも横に長すぎたので分割しました。名前はもっといいのがあると思います。
const modelValue = ref("a"); | ||
return { args, modelValue }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
エラーを吐いていたのでmodelValueを増やしました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ほぼLGTMです!!!
簡潔なプルリクエストありがとうございます!!!レビューしやすいです!!!
plugins: [ | ||
vue(), | ||
quasar({ autoImportComponentCase: "pascal" }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quasar Vite Plugin周りでエラーを吐いていた雰囲気があったので消しました。store/utility.tsの変更はそれに伴うものです。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
・・・これなんのために必要だったんですかね! 消しちゃって良さそう!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あの後やっぱり戻しました(警告消すためにQuasarのバージョンを上げようとしていたらプラグインなしで動かなくなった)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なるほどです!
変な差分が発生しちゃってるのでこっちで戻しちゃいます 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
おそらくこのPRと関係ないのですが、もしよかったらテストが落ちてるのもついでに直しちゃっていただけると・・・!!!! 🙇
修正しました。 |
そういえば:storybook/test-runnerとpatch-packageが不要担ったので消しました。いい話。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
apply patch不要になったのめでたい!!
ユニットテストを実行する方法がREADMEで数パターン案内されてて、初学者の人はどれ使えばいいかわからないかもですね。
しばらくtest-ui
使ってみて、便利そうだと判断したら「これがオススメ!」的な案内をしても良さそう。
useQuasar見て回った感じ、大半が不要にできそうですねぇ。(ただのコメントです)
package.json
Outdated
@@ -116,18 +120,19 @@ | |||
"happy-dom": "8.4.2", | |||
"license-checker-rseidelsohn": "4.3.0", | |||
"markdownlint-cli": "0.37.0", | |||
"patch-package": "8.0.0", | |||
"npm-run-all2": "6.2.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
便利だけど、依存増やすほどでもない気がしますねぇ。
ちょっとこっちで削除させていただきます!
plugins: [ | ||
vue(), | ||
quasar({ autoImportComponentCase: "pascal" }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なるほどです!
変な差分が発生しちゃってるのでこっちで戻しちゃいます 🙏
マージします!!! 使っていきたい!!!! |
内容
StorybookのVitest統合を使う用にします。
関連 Issue
(なし)
スクリーンショット・動画など
その他
(なし)