add: リクエストのノートにNoteIdを代入可能にし、音素ごとに元のノートIDが紐づくようにする #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
commented
Oct 5, 2024
| @@ -65,6 +65,7 @@ const createNotesForRequestToEngine = ( | |||
| ); | |||
| const noteOffFrame = Math.round(noteOffSeconds * frameRate); | |||
| notesForRequestToEngine.push({ | |||
| id: note.id, | |||
There was a problem hiding this comment.
ここでエディタ側が持つノートIDをエンジン側に送ってます。
前後の空白用のノートがあるのですが、そっちは今 ID 振られてなかったので、特に振らないようにしました。
もしpauも挿入できるようにするならID振る必要があるかも。
Hiroshiba
commented
Oct 5, 2024
| @@ -383,6 +383,7 @@ const getFeatureName = (name: keyof SupportedFeatures) => { | |||
| adjustPitchScale: "全体の音高の調整", | |||
| adjustIntonationScale: "全体の抑揚の調整", | |||
| adjustVolumeScale: "全体の音量の調整", | |||
| adjustPauseLength: "句読点などの無音時間の調整", | |||
There was a problem hiding this comment.
|
@sigprogramming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
将来音素編集が入ると、どの音素がどのノートと結びついているかの情報が必要になります。
エンジンへのリクエストにノート ID を付与し、エンジンが返す情報にノート ID が付与されていればOKです。
エンジン側はこのプルリクエストで実装されていたので、エディタ側も追従しました。
特に機能的な変更はありません。
関連 Issue
その他