Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: definePropsのimportは不要らしいので削除 #2244

Merged
merged 1 commit into from
Aug 21, 2024
Merged

refactor: definePropsのimportは不要らしいので削除 #2244

merged 1 commit into from
Aug 21, 2024

Conversation

Hiroshiba
Copy link
Member

内容

このようなwarningが出ていたので、該当箇所を削除してみました。

[@vue/compiler-sfc] `defineProps` is a compiler macro and no longer needs to be imported.
[@vue/compiler-sfc] `defineEmits` is a compiler macro and no longer needs to be imported.

その他

@Hiroshiba Hiroshiba requested a review from a team as a code owner August 21, 2024 18:46
@Hiroshiba
Copy link
Member Author

たぶん問題ないのでマージします！

@Hiroshiba Hiroshiba merged commit 38c4f18 into VOICEVOX:main Aug 21, 2024
9 checks passed
@Hiroshiba Hiroshiba deleted the definePropsのimportは不要らしい branch August 21, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Hiroshiba