fix: fix logging in i18n #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razdva122
approved these changes
Oct 7, 2024
kobezzza
reviewed
Oct 7, 2024
src/core/prelude/i18n/helpers.ts
Outdated
| @@ -91,13 +94,13 @@ export function i18nFactory( | |||
| * console.log(examplePluralize); // '5 products' | |||
| * ``` | |||
| */ | |||
| export function resolveTemplate(value: Translation, params?: I18nParams, opts: I18nOpts = {}): string { | |||
| export function resolveTemplate(value: Translation, params?: I18nParams, opts: I18nOpts = {}, meta?: I18nMeta): string { | |||
There was a problem hiding this comment.
Как то дохрена аргументов выходит. Я уже запутался.
There was a problem hiding this comment.
Например, почему meta нельзя сделать частью opts
There was a problem hiding this comment.
@kobezzza
opts - для настройки перевода. Например прокинуть правила плюрализации или настройки формата чисел.
meta - мета информация о текущем переводе. Язык, кейсеты, ключ и т.д.
meta никак не влияет на логику переводов, поэтому посчитал странным делать это частью opts.
В перспективе больше параметров появляться не должно.
added 2 commits
October 7, 2024 17:03
added 2 commits
October 8, 2024 14:48
This reverts commit 382b424.
kobezzza
approved these changes
Oct 9, 2024
added 2 commits
October 10, 2024 15:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.