Merge pull request #383 from V4Fire/fix/provider-cache

Fix/provider cache

CHANGELOG.md

@@ -11,6 +11,12 @@ Changelog
 
 _Note: Gaps between patch versions are faulty, broken or test releases._
 
+## v4.0.0-alpha.16 (2023-12-19)
+
+#### :bug: Bug Fix
+
+* Fixed cache initialization for providers
+
 ## v4.0.0-alpha.15 (2023-11-26)
 
 #### :rocket: New Feature

package.json

@@ -5,7 +5,7 @@
   "main": "lib/core/index.js",
   "typings": "index.d.ts",
   "license": "MIT",
-  "version": "4.0.0-alpha.15",
+  "version": "4.0.0-alpha.16",
   "author": "kobezzza <[email protected]> (https://github.com/kobezzza)",
   "repository": {
     "type": "git",

src/core/data/CHANGELOG.md

@@ -9,6 +9,12 @@ Changelog
 > - :house:      [Internal]
 > - :nail_care:  [Polish]
 
+## v4.0.0-alpha.16 (2023-12-19)
+
+#### :bug: Bug Fix
+
+* Fixed cache initialization for providers
+
 ## v4.0.0-alpha.12 (2023-10-17)
 
 #### :rocket: New Feature

src/core/data/interface/types.ts

@@ -78,7 +78,9 @@ export interface ProviderOptions {
 	socket?: boolean;
 
 	/**
-	 * If false, the instance of the data provider will not be cached
+	 * By default, all instances of data providers are created as singletons
+	 * to enable efficient caching between consumers.
+	 * Setting this option to false will disable this behavior.
 	 */
 	singleton?: boolean;
 }

src/core/data/modules/base.ts

@@ -112,15 +112,16 @@ export default abstract class Provider extends ParamsProvider implements IProvid
 			id = this.getCacheKey(opts),
 			cacheVal = instanceCache[id];
 
-		if (opts.singleton === false) {
+		if (opts.singleton !== false) {
 			if (cacheVal != null) {
 				return <this>cacheVal;
 			}
 
 			instanceCache[id] = this;
-			requestCache[id] = Object.createDict();
 		}
 
+		requestCache[id] = Object.createDict();
+
 		this.cacheId = id;
 		this.params = opts;