fix: xpress pdfs #952
Merged
fix: xpress pdfs #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct/user-office-core into uop-1338-fix-xpress-pdfs
mutambaraf
requested review from
simonfernandes
and removed request for
a team
mutambaraf
requested review from
a team and
bolmsten
and removed request for
a team
simonfernandes
approved these changes
Feb 14, 2025
RasmiaKulan
approved these changes
Feb 14, 2025
yoganandaness
requested review from
yoganandaness
and removed request for
bolmsten
yoganandaness
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the issue were proposal pdfs where generated with missing attachments and technique answers for a technique question that was use as a dependency on another question.
Motivation and Context
Proposals pdfs had missing information.
How Has This Been Tested
Manual
Fixes
Closes: UserOfficeProject/issue-tracker#1338
Changes
Updated
addTopicInformationinapps/backend/src/factory/pdf/proposal.tsso it does not mutate the underlining object state when we set answer value.Depends on
UserOfficeProject/user-office-factory#609
Tests included/Docs Updated?