feat: add isRequired option for generic template questions #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepaksftc
requested review from
a team and
martin-trajanovski
and removed request for
a team
deepaksftc
requested review from
mehta-pooja123,
a team,
bolmsten and
EdwardHaynes
and removed request for
a team and
martin-trajanovski
deepaksftc
requested review from
a team and
Scott-James-Hurley
and removed request for
a team
Scott-James-Hurley
approved these changes
Jan 28, 2025
yoganandaness
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces an "isRequired" option for generic template questions in the application.
Motivation and Context
Previously, there was no way to mandate the input for generic template questions. This was causing issues as some responses were left blank by users, leading to incomplete data. This feature aims to solve this problem by allowing the option to make these questions required.
Changes
genericTemplateDefinitioninGenericTemplateDefinition.tsx. This checks if the configuration requires an answer and adjusts the schema accordingly.QuestionGenericTemplateForm.tsxandQuestionTemplateRelationGenericTemplateForm.tsxto allow users to mark a question as required.How Has This Been Tested?
Fixes Jira Issue
UserOfficeProject/issue-tracker#1180
Depends On
Tests included/Docs Updated?