-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate stfc users service to rest #897
Conversation
…ffice-core into migrate-rest-new
…ffice-core into migrate-rest-new
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but have we resolved adding openapi.yaml
to this repo
I don't see how we could avoid including an api spec or client. We need a client for the code to compile, so we either include that as client code, or the service definition to generate one at build time. I guess it might be possible to have the client as a separate npm package, but the extra infrastructure for that seems excessive compared to just adding an npm command and yaml file here. And it's not like having a client/spec here is new, the old |
I agree with alex, I don't see a way around adding the open-api file or the compiled code to this repo without massive hassle to both us and other collaborators. I think I prefer adding the |
We have more like a month to come up with a package which l think might be a good solution here. |
Sure we've got a month, but what is the problem that having a separate package would address? It'd be adding extra steps to our update process if we need a new client to pull in UOWS updates, and giving us more infrastructure to maintain, so there'd have to be some benefit for that to be worth it, but I don't see what that would be. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! But please don't forget to review the two comments I've added, and adjust as you see fit.
I have made the requested changes
Closes UserOfficeProject/issue-tracker#1060
Description
This PR introduces REST changes to the application, replacing SOAP with REST in STFC UserOfficeWebService, and updating relevant configurations and dependencies.
Motivation and Context
The change is required to migrate from the SOAP-based STFC UserOfficeWebService to a REST-based service. This will provide a more modern, efficient, and easy-to-maintain approach to data communication, ultimately improving the performance and reliability of the application.
Please find the mock server pr below.
UserOfficeProject/mock-uows#18
Please find the docker orchestration pr below.
https://github.com/isisbusapps/docker-orchestration/pull/687
Changes
How Has This Been Tested?
Fixes Jira Issue
https://jira.esss.lu.se/browse/
Depends On
Tests included/Docs Updated?