Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports already parsed documents when merging types #83

Merged
merged 1 commit into from
Sep 1, 2017
Merged

Supports already parsed documents when merging types #83

merged 1 commit into from
Sep 1, 2017

Conversation

kamilkisiela
Copy link
Collaborator

@kamilkisiela kamilkisiela commented Aug 29, 2017

It allows for doing this:

import userType from './user.graphql';

const postType = `
  type Post {
    title: String!
  }
`;

mergeTypes([
  userType,
  postType
]);

Reason of polyfill.js with Object.values: jestjs/jest#3687 (comment)

@RichardLitt RichardLitt added the 🚀enhancement New feature or request label Aug 29, 2017
@RichardLitt RichardLitt requested a review from RodMachado August 29, 2017 15:28
@Urigo
Copy link
Owner

Urigo commented Aug 30, 2017

@RichardLitt is the king!

@RichardLitt
Copy link
Contributor

Uh, thanks @Urigo. Not really relevant to this thread, though!

@kamilkisiela We'll get to this as soon as we can. :)

@kamilkisiela
Copy link
Collaborator Author

@RichardLitt great!

Copy link
Contributor

@RodMachado RodMachado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamilkisiela
LGTM, great job!

@RodMachado RodMachado merged commit 08aeae9 into Urigo:master Sep 1, 2017
@kamilkisiela kamilkisiela deleted the support-parsed branch September 1, 2017 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants