-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update paths used in pipeline #71
Conversation
* Update reading activity chains dataframe to use config path * Add boundaries and osmox filepaths to config
config.init_rng() | ||
os.makedirs(acbm.root_path / "data/interim/osmox", exist_ok=True) | ||
fp = get_data(config.region, directory=acbm.root_path / "data/interim/osmox") | ||
config = load_and_setup_config(config_file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fallback for when pyrosm fails
This looks great to me! Happy to merge it Only one minor comment on logging: It seems some src code is using the old logging setup. Would this conflict with your new imlementation? e.g.
|
Thanks @Hussein-Mahfouz - merging now with comments addressed or opened as new issues. |
Closes #53.
The following changes are included in this PR:
@property
methods within the config providing the paths and refactor scripts to use thesePopulation
class for reading pipeline outputspyrosm
fails (e.g. for West Yorkshire)Remaining tasks:
travel_times = false
currently scriptupdating optimization for only total deviation and adding multiprocessing for 3.3 enables pipeline to completely run.3.2.2_assign_primary_zone_work.py
is not progressing, consider alternative parameters for the optimization