docs: update firewall_rule action description #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the collaboration! Few notes: The title would need to include a conventional commit message prefix, in this case it would be Also, the docs themselves can't be modified directly as they are generated from the source code. This particular change would be done in https://github.com/UpCloudLtd/terraform-provider-upcloud/blob/main/internal/service/firewall/firewall.go#L60 . |
MarcusC-UpCloud
changed the title
MarcusC-UpCloud
force-pushed
the
patch-1
branch
from
97925c1 to
f0875be
Compare
|
Hey! The git commit has been changed to the correct one for the .go file A new title was given to the PR in line with the standard naming convention |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a description for possible action, Default action values either "Accept" or "Drop"