This repository has been archived by the owner on Oct 27, 2022. It is now read-only.
Upgrade webpack #86
Merged
Upgrade webpack #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #83
SimenB
commented
Jul 7, 2017
package.json
Outdated
| "identity-obj-proxy": "^3.0.0", | ||
| "jest": "^20.0.4", | ||
| "node-sass": "~3.12.1", | ||
| "postcss-loader": "^0.13.0", |
SimenB
commented
Jul 7, 2017
| @@ -34,7 +34,7 @@ function storeApplicationMetaData (appName, key, value) { | |||
| }).then(throwIfNotSuccess); | |||
| } | |||
|
|
|||
| module.exports = { | |||
There was a problem hiding this comment.
all of these import/export changes were because webpack complained
SimenB
commented
Jul 7, 2017
| @@ -1,9 +1,12 @@ | |||
| { | |||
| "presets": ["react", "es2015", "stage-2"], | |||
| "presets": ["react", ["es2015", {"modules": false}], "stage-2"], | |||
There was a problem hiding this comment.
might consider preset-env?
sveisvei
approved these changes
Jul 7, 2017
|
@sveisvei did you test it? Afraid we might hit webpack-contrib/extract-text-webpack-plugin#548 (comment) |
ivarconr
approved these changes
Jul 10, 2017
ivarconr
reviewed
Aug 4, 2017
| "build:html": "cp public/*.html dist/.", | ||
| "build:ico": "cp public/*.ico dist/.", | ||
| "build:img": "cp public/*.png dist/public/.", | ||
| "start": "NODE_ENV=development webpack-dev-server --config webpack.config.js --progress --colors", | ||
| "start": "NODE_ENV=development webpack-dev-server --progress --colors --display-optimization-bailout", |
There was a problem hiding this comment.
webpack-dev-server says Unknown argument: display-optimization-bailout!
There was a problem hiding this comment.
Ah, I didn't actually test that... It can be removed, it's really just useful for production
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83
You should probably test this properly before merge.
A build works, and the dev server started, but I didn't start up the API, so haven't tested navigating