-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: client identification headers #342
Conversation
UnleashClient/__init__.py
Outdated
# Setup | ||
metrics_args = { | ||
"url": self.unleash_url, | ||
"app_name": self.unleash_app_name, | ||
"instance_id": self.unleash_instance_id, | ||
"custom_headers": self.unleash_custom_headers, | ||
"custom_headers": headers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's okay to pass this like this but this does now mean that this isn't just custom headers and the places where the callees are receiving this are now misleading
Any chance we can rename those call sites to "headers" or something clearer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like so: fc4685f ?
Can you run the example app https://github.com/Unleash/unleash-sdk-examples/tree/main/Python with the latest version after publishing this package and checking the headers work in the user space code? |
Verified with real-world app |
Description
Identification headers consistent with other Unleash SDKs.
Fixes issue/1-3274
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: