Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/error when using update context #93

Merged
merged 8 commits into from
Nov 16, 2022
Merged

Fix/error when using update context #93

merged 8 commits into from
Nov 16, 2022

Conversation

FredrikOseberg
Copy link
Contributor

About the changes

  • Fixes an issue where using updateContext would try to reach the API and the API was unavailable it would trigger a loop because we were listening on an error event and updating state based off this event.

Fixes #92

Closes #

Important files

Discussion points

@FredrikOseberg FredrikOseberg merged commit 5d29f86 into main Nov 16, 2022
@FredrikOseberg FredrikOseberg deleted the fix/error-when-using-updateContext branch November 16, 2022 15:49
yarinsa
yarinsa reviewed Nov 16, 2022
View reviewed changes
Copy link

@yarinsa yarinsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarinsa yarinsa yarinsa left review comments

@kwasniew kwasniew kwasniew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unleash created infinite loop when proxy server is down
3 participants
@FredrikOseberg @kwasniew @yarinsa