Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UAAL example to support Gradle 8 in 2023.3.0b7+ #99

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

manugildev
Copy link
Contributor

@manugildev manugildev commented Feb 12, 2024

Purpose of this PR

This PR fixes compatibility with Unity 2023.3.0b7+ that ships with Gradle 8 and Android SDK 34.

  • Manual testing of demo project in both Activity and GameActivity

Comments to reviewers

The changes introduced by this PR are backwards compatible, meaning we don't need to create a new 23LTS branch to just support 2023.3.0b7+.

@VeryHappyYoung
Copy link
Contributor

Hello. Thank you for your work.

I think you need to update some lines in android.md. I read Tomas said "after gradle tools update, you can no longer use Android Studio 2021.3.1" so you need to update Android Studio version (and Unity version).

This was the android.md I tried to update in my PR last time but I am not sure if this will still work with gradle tools update.

BTW, do you happen to know which version of Unity the gradle tools update has been applied to? I guess we need to check the other branches for that.

@manugildev
Copy link
Contributor Author

manugildev commented Feb 13, 2024

@VeryHappyYoung

I think you need to update some lines in android.md. ...
This was the android.md I tried to update in my PR last time but I am not sure if this will still work with gradle tools update.

Just updated the android.md to indicate the new Android Studio version recommended to run the project. (2895624)

BTW, do you happen to know which version of Unity the gradle tools update has been applied to? I guess we need to check the other branches for that.

The platform tools upgrade was done in 2023.3.0b7, I have tested this changes on 2023.3.0b6, 2023.2.0b3, and 2023.1.7f1 and everything works fine. My changes should be backward compatible, that's why I haven't suggested making a new 23LTS branch.

@manugildev manugildev merged commit 456e082 into master Feb 13, 2024
1 check passed
@manugildev manugildev deleted the platform/android/upgrade-gradle-8-2023.3.0b7+ branch April 26, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants