Sorted dependencies #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -176,7 +177,8 @@ internal IEnumerable<MessageSystem.Message> GetMessages() | |||
| if (m_dependencies != null && m_dependencies.Count > 0) | |||
| { | |||
| var message = string.Empty; | |||
| foreach (var dependent in m_dependencies) | |||
| List<AssetInfo> sortedDependencies = m_dependencies.OrderBy(d => d.bundleName).ToList(); | |||
There was a problem hiding this comment.
The .ToList() is redundant, since the foreach will work with the default return value of OrderBy. We also tend to use var for local variables - so this could be simplified just a bit to var sortedDependencies = m_dependencies.OrderBy(d => d.bundleName);
There was a problem hiding this comment.
Thanks, those are good points. I've updated them to keep it consistent with the rest!
using var and skipping the .ToList() as per feedback
BrettKercher
approved these changes
Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a lot of dependencies, it becomes a bit cluttered, sorting by bundle name makes it a lot easier to navigate