Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated metamask events #158

Closed
wants to merge 3 commits into from
Closed

Conversation

EdsonAlcala
Copy link

Hello, I'm seeing warning about deprecated events and I fix a couple of them.

  1. Removed networkChanged listener (https://docs.metamask.io/guide/ethereum-provider.html#networkchanged-deprecated)

  2. Rename close to disconnect (https://docs.metamask.io/guide/ethereum-provider.html#close-deprecated)

Thanks

@jhirn
Copy link

jhirn commented Oct 15, 2021

Would love to see this and related metamask warnings get merged.

@Olshansk
Copy link

@jhirn
Copy link

jhirn commented Oct 24, 2021

I was attempting to use resolutions in order to point to a patched version of the injected-connector on my personal github but couldn't seem to get it to work. I should note i'm using this library as dependency of useDapp so it's two levels down.

What would a package.json look like that's pointing to a forked and patched version of injectedConnector. That would at least help me work around this issue.

@greg-nagy
Copy link

@jhirn I have used this in the past to change dependency package code in my projects: https://www.npmjs.com/package/patch-package

This might help you out if you still have the issues.

@jhirn
Copy link

jhirn commented Dec 4, 2021

Thx @greg-nagy. I might give it a show but this repo seems to be heading away from web3-react library all together which will be a very good thing.

@khanhhaquang
Copy link

How is the status of this update ?

1 similar comment
@ahmadina
Copy link

ahmadina commented Jan 6, 2022

How is the status of this update ?

@adshodgson
Copy link

I can't wait for this ...Switching to Avax defaults to chainId 1 this will solve so many issues for me.

@NoahZinsmeister
Copy link
Contributor

hi all - sorry for the non-response on this. i'm going to be focusing development efforts on the v8 of this library going forward, which has a shiny, modern metamask connector, and hopefully addresses these issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants