Add weth wrapping hook #436
Conversation
|
Note one constraint of this approach is that the input currency must already exist in poolmanager before the swap call. This could either be from existing standing liquidity or else the user must transfer input assets first |
| /// @dev This contract provides the base functionality for wrapping/unwrapping tokens through V4 pools | ||
| /// @dev All liquidity operations are blocked as liquidity is managed through the underlying token wrapper | ||
| /// @dev Implementing contracts must provide deposit() and withdraw() functions | ||
| abstract contract BaseTokenWrapperHook is BaseHook { |
There was a problem hiding this comment.
imo we should be removing the inheritance of SafeCallback that’s happening into BaseHook. I don’t think that should be in there - not all hooks are going to take out locks on the PM (eg this one) so it’s an unnecessary addition.
Could be a separate PR just putting this thought here.
|
|
||
| if (isWrapping) { | ||
| uint256 inputAmount = | ||
| isExactInput ? uint256(-params.amountSpecified) : _getWrapInputRequired(uint256(params.amountSpecified)); |
There was a problem hiding this comment.
technically its not safe to invert a negative number without safecast/checking whether the value is the minimum integer. Although I cant think of an attack vector. We do have a large SafeCast.sol in core you can use for most of these things
There was a problem hiding this comment.
not totally sure what you mean here - what is the problem if it's the minimum integer? and how does safecast help?
There was a problem hiding this comment.
also theres no int256 => uint256 function in that library
| uint256 inputAmount = | ||
| isExactInput ? uint256(-params.amountSpecified) : _getWrapInputRequired(uint256(params.amountSpecified)); | ||
| poolManager.take(underlyingCurrency, address(this), inputAmount); | ||
| uint256 wrappedAmount = deposit(inputAmount); |
There was a problem hiding this comment.
is it worth deposit just handling a uint128 or smaller, given you have to cast up to uint256 before this, and then back down later
There was a problem hiding this comment.
hmm ok did this but not sure its really any cleaner
There was a problem hiding this comment.
just pushes the weird casting down into the inheriting contracts
token wrapper adapter
Overview
This PR introduces a WETH (Wrapped Ether) hook for Uniswap v4, enabling native ETH to WETH conversions directly through v4 pools. The implementation provides a convenient way to wrap and unwrap ETH within a v4 lock / route.