move the oracle into a hook, remove time based stuff from pool manager #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willpote
reviewed
Apr 19, 2022
Comment on lines
+35
to
+36
| /// @notice Get the current value in slot0 of the given pool | ||
| function getSlot0(PoolKey memory key) external view returns (uint160 sqrtPriceX96, int24 tick); |
There was a problem hiding this comment.
Why do we unpack this? Why not return the Slot0 struct?
There was a problem hiding this comment.
the slot0 struct feels like an internal thing, consumers shouldn't need to know about it, although it was exposed in the previous versions and also named that...
There was a problem hiding this comment.
In that case should we rename this to something like getPrice so the term slot0 remains internal?
There was a problem hiding this comment.
i'd rather defer the issue, it was named slot0 because in the past it contained other stuff that wasn't just the price or easily categorized except that they all were packed in slot 0. we don't know what else will go in the slot later
…ean oracle to be a single pool with locked liquidity
# Conflicts: # contracts/PoolManager.sol # test/__snapshots__/PoolManager.gas.spec.ts.snap # test/__snapshots__/PoolManager.spec.ts.snap
willpote
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #53
fixes #64