Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the privacy of the merkle drop claim info request #1337

Closed
moodysalem opened this issue Mar 17, 2021 · 1 comment · Fixed by #1698
Closed

Improve the privacy of the merkle drop claim info request #1337

moodysalem opened this issue Mar 17, 2021 · 1 comment · Fixed by #1698
Labels
improvement Improves the ux p2 Nice to have

Comments

@moodysalem
Copy link
Contributor

Bug Description
The merkle drop request is always sent for the user, regardless of their intent to claim. Putting this feature on its own page will avoid making unnecessary requests which leak user information.

Related to improvement #1334
@moodysalem moodysalem added bug Something isn't working p2 Nice to have improvement Improves the ux and removed bug Something isn't working labels Mar 17, 2021
@moodysalem
Copy link
Contributor Author

moodysalem commented Apr 23, 2021 •
edited
Loading

Better yet, don't rely on the API, just use a smaller version of the file from https://mrkl.uniswap.org containing only unclaimed keys
We still have about 60MB worth of claim data--we could have a 2 stage fetch where the first one only contains addresses, but this seems unnecessarily complex vs. just removing the request

moodysalem added a commit that referenced this issue May 24, 2021
@moodysalem
fix: improve privacy of the claim popup
e054f40 
fixes #1337
@moodysalem moodysalem mentioned this issue May 24, 2021
Merged
@moodysalem moodysalem changed the title Only make the merkle drop request if the user is at a certain page Improve the privacy of the merkle drop claim info request May 24, 2021
moodysalem added a commit that referenced this issue May 24, 2021
@moodysalem
fix: improve privacy of the claim popup (#1698)
85d8b1e 
* fix: improve privacy of the claim popup

fixes #1337

* fix unhandled rejection

* clean up the claim code a bit more

* working claim fetch

* working claim fetch

* trigger some events on the claim popup
daniel-dev1990 pushed a commit to daniel-dev1990/uniswap-interface that referenced this issue Jul 8, 2021
@moodysalem
fix: improve privacy of the claim popup (Uniswap#1698)
351b3ea 
* fix: improve privacy of the claim popup

fixes Uniswap#1337

* fix unhandled rejection

* clean up the claim code a bit more

* working claim fetch

* working claim fetch

* trigger some events on the claim popup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improves the ux p2 Nice to have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve privacy of the claim popup Uniswap/interface
1 participant
@moodysalem