try to write all attributes as NC_CHAR (issue #529) #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to ascii, then write NC_CHAR if possible.
| # try to convert to ascii string, write as NC_CHAR | ||
| # else it's a unicode string, write as NC_STRING (if NETCDF4) | ||
| try: | ||
| if force_ncstring: raise UnicodeDecodeError("",b"",1,1,"") |
There was a problem hiding this comment.
Why do you need this strange argument here to UnicodeDecodeError?
There was a problem hiding this comment.
Because UnicodeDecodeError has 5 mandatory args
that all have to be specified to raise it manually.
There was a problem hiding this comment.
Changed it to UnicodeError, which doesn't require args.
jswhit
added a commit
that referenced
this pull request
Mar 1, 2016
try to write all attributes as NC_CHAR (issue #529)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only write NC_STRING if it can't be converted to ascii.