Fixed f90tst_parallel3.F90 parallel test #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR; the tests had failed so I've restarted them and will follow back up if they fail again. |
|
Seeing a number of fortran related failures, will see if I observe them outside the docker environment. |
|
Failures can be observed here: |
|
Ok stand by. |
|
I'll fall back to the previous PR and circle around to this one again when it is merged. Thanks! Ed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #157.
Fixes #155
In this PR I remove the nfconfig file and all its related trappings.
In netcdf-fortran, I started with a configure.in file (written by Steve) and added automake (and changed the name, as was recommended, to configure.ac).
So some of what is present is simply an artifact of those times, and the nfconfig.inc is part of that. Because the netCDF-c build used config.h, we had an equivalent for fortran.
But since then I have learned a lot more about autotools and fortran and done several more fortran packages. Fortran does better without a config file, since there is no standard for fortran pre-processing. Instead, defining macros with the -D option to compilers works best.
So that is what is implemented here. This causes the parallel tests to run again, and I had to comment a couple of them out because they fail. I will hit that in my next PR. ;-)
In this PR I also fix one of the two currently broken parallel tests.