remove legacy cfortran.h build, change valgrind use #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW I have built up my CI for netcdf-fortran. I'm not testing agains 4.6.0, 4.6.1, 4.6.2, and a recent 4.6.3-development versions of netcdf-c, for standard and parallel I/O autotools builds, as well as a few variants. Also I am now doing some cmake builds... |
|
@DennisHeimbigner Thoughts on this? |
DennisHeimbigner
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118
Fixes #115.
Fixes #114.
Fixes #85.
This PR removes the ability to build with an F77-only Fortran compiler. It does not remove the F77 API, which remains fully supported and working fine. ;-)
The current build has the capability to build the netCDF F77 API (only) with a F77-only compiler. But by default, it builds both the F90 and F77 APIs, using a modern fortran compiler which can handle both.
When I first put the autotools build together, we took the perhaps too-cautious decision to preserve the ability to build with F77-only compilers, even though F2003 compilers were widespread at that time.
Now the only f77-only compiler that is still around is g77, and it is in maintenance mode. So it is very safe to remove this capability from the build. (I probably never should even have supported it.)
The F77-only build was based on a giant header file called cfortran.h, which, depending on the specific compiler, did various macro magic to allow C and Fortran to communicate. Debugging cfortran.h problems was a nightmare, but fortunately, in practice F77 compilers only used a fraction of the goop in cfortran.h, and it all worked.
Removing the cfortran.h build clears out a lot of complexity from the build system.
This PR includes my other outstanding PR #116.