Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid overriding CMAKE_BUILD_TYPE #96

Closed
letmaik opened this issue Aug 10, 2018 · 1 comment
Closed

Avoid overriding CMAKE_BUILD_TYPE #96

letmaik opened this issue Aug 10, 2018 · 1 comment
Assignees
@WardF
Milestone
4.4.5

Comments

@letmaik
Copy link

letmaik commented Aug 10, 2018

netcdf-fortran/fortran/CMakeLists.txt

Line 4 in dd10554

SET(CMAKE_BUILD_TYPE "RelWithDebInfo")

@WardF WardF self-assigned this Aug 20, 2018
@WardF WardF added this to the 4.4.5 milestone Aug 20, 2018
WardF added a commit that referenced this issue Aug 20, 2018
@WardF
Updated release notes, also avoid overriding CMAKE_BUILD_TYPE in supp…
074a8c1 
…ort of #96
@WardF
Copy link
Member

WardF commented Aug 20, 2018

Thanks! Addressing this and #92 in a pull request I'm preparing now.

@WardF WardF mentioned this issue Aug 20, 2018
Merged
@WardF WardF closed this as completed in #97 Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WardF WardF

Labels
None yet
Projects
None yet
Milestone
4.4.5
Development

No branches or pull requests
2 participants
@letmaik @WardF