Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default_chunk_cache_size #3077

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

WardF
Copy link
Member

@WardF WardF commented Jan 16, 2025

@WardF WardF self-assigned this Jan 16, 2025
@edwardhartnett
Copy link
Contributor

Really? This solves it?

@WardF
Copy link
Member Author

WardF commented Jan 16, 2025

Really? This solves it?

This solves it. I'm playing around with a smaller (small enough to be part of version control) test file to see if I can incorporate this into our CI. In the meantime, here's the test directory/script I was using, modified from the script I tossed together for the initial git-bisect.

@WardF
Copy link
Member Author

WardF commented Jan 16, 2025

The results observed on my system:

vagrant@ubuntu2410gdm:~/Desktop/test/netcdf-c$ ../mytest.sh 
	o Default chunk cache size: 67108864 (should pass)
		o Configuring
		o Building
		o Installing to temporary location /home/vagrant/tmp
		o Running test program. Expected to pass.
Storm 13408: Latitude is 13.800000, Time taken = 30.770 ms
Storm 13409: Latitude is 12.400000, Time taken = 0.021 ms
Storm 13410: Latitude is 16.799999, Time taken = 0.006 ms
Storm 13411: Latitude is -10.300000, Time taken = 0.005 ms
Storm 13412: Latitude is -12.700000, Time taken = 0.003 ms
Storm 13413: Latitude is 12.400000, Time taken = 0.004 ms
Storm 13414: Latitude is -11.000000, Time taken = 0.004 ms
Storm 13415: Latitude is 10.400000, Time taken = 0.005 ms
Storm 13416: Latitude is -11.900000, Time taken = 0.004 ms
Storm 13417: Latitude is -17.299999, Time taken = 0.004 ms

Average runtime per iteration: 3.083 ms

-------------------------------------

	o Default chunk cache size: 16777216U (should fail)
		o Configuring
		o Building
		o Installing to temporary location /home/vagrant/tmp
		o Running test program. Expected to fail.
Storm 13408: Latitude is 13.800000, Time taken = 31.398 ms
Storm 13409: Latitude is 12.400000, Time taken = 29.782 ms
Storm 13410: Latitude is 16.799999, Time taken = 29.809 ms
Storm 13411: Latitude is -10.300000, Time taken = 29.954 ms
Storm 13412: Latitude is -12.700000, Time taken = 29.813 ms
Storm 13413: Latitude is 12.400000, Time taken = 29.798 ms
Storm 13414: Latitude is -11.000000, Time taken = 29.898 ms
Storm 13415: Latitude is 10.400000, Time taken = 29.955 ms
Storm 13416: Latitude is -11.900000, Time taken = 30.043 ms
Storm 13417: Latitude is -17.299999, Time taken = 29.906 ms

Average runtime per iteration: 30.036 ms
	o [x] Error caught.
vagrant@ubuntu2410gdm:~/Desktop/test/netcdf-c$ 

@WardF WardF merged commit 2e30f8c into Unidata:main Jan 17, 2025
107 checks passed
@WardF WardF deleted the fix-performance-cache-setting.wif branch January 17, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Severe performance degradation in 4.9.3-rc2
3 participants