Add zstd test and fix plugin build for CMake/Cygwin #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardhartnett
requested review from
WardF and
DennisHeimbigner
as code owners
DennisHeimbigner
previously approved these changes
Aug 17, 2024
o Added information related to plugins, plugin install location to post-build summary.
|
Looks good! Made a small change to include information in the libnetcdf.settings file post-configure/cmake, once those tests pass I'll merge it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2980
Fixes #2938
In this PR I get the CMake build working with zstd on cygwin.
Also I add a zstd test which is run when plugins are enabled and zstd is found.