-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 Mode url reconstruction defaults to wrong server type #2947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending tests passing.
The failures appear unrelated to the PR, and are part of an issue we're fixing on the Unidata side. This looks good and will be merged shortly. |
The certificate issue on our end is resolved so I'm re-running the jobs; hopefully this should all pass, and we'll get this merged! Thanks! |
Thanks fo this. We did not support this case because we could find a test site. |
The current failure is the result of a combination of two different PRs which both passed checks, but combined, are resulting in a strange error. Once we get that fixed we can re-run the checks and merge this. @DennisHeimbigner this is related to the anonymous dimension issue I reached out about. |
We faced an issue when using ncdump to read Zarr from a S3 instance that is not hosted by AWS or Google.
Noting the "dummy" host on the url of the command above, unfortunately it works. This is because on this NC_s3urlrebuild call,
uri->host
is overwritten to the default:storage.googleapis.com
.In this PR:
NCS3UNK != NCS3GS
- fixing the issue.host
of aurl
to inferbucket
andregion
inference, similar to AWS.(edit: links)