Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: (deps): Bump matplotlib from 3.9.3 to 3.10.0 in /ci #3716

Merged
merged 2 commits into from
Dec 18, 2024
Merged

CI: (deps): Bump matplotlib from 3.9.3 to 3.10.0 in /ci #3716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
209dc68
CI: (deps): Bump matplotlib from 3.9.3 to 3.10.0 in /ci
dependabot[bot] Dec 16, 2024
acf1089
MNT: Update some test images/thresholds for Matplotlib 3.10
dopplershift Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
matplotlib==3.9.3
matplotlib==3.10.0
numpy==2.2.0
pandas==2.2.3
pooch==1.8.2
Expand Down
Binary file modified tests/plots/baseline/test_declarative_events.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/plots/baseline/test_declarative_image.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/plots/baseline/test_global.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/plots/baseline/test_latlon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 7 additions & 4 deletions tests/plots/test_declarative.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
from metpy.units import units


@pytest.mark.mpl_image_compare(remove_text=True, tolerance=0.02)
@pytest.mark.mpl_image_compare(remove_text=True,
tolerance=2.58 if version_check('matplotlib<3.10') else 0.0081)
@needs_cartopy
def test_declarative_image():
"""Test making an image plot."""
Expand Down Expand Up @@ -474,7 +475,7 @@ def test_declarative_contour_convert_units():


@pytest.mark.mpl_image_compare(remove_text=True,
tolerance=2.731 if version_check('matplotlib<3.9') else 0.246)
tolerance=5.34 if version_check('matplotlib<3.10') else 0.246)
@needs_cartopy
def test_declarative_events():
"""Test that resetting traitlets properly propagates."""
Expand Down Expand Up @@ -802,7 +803,8 @@ def test_colorfill_no_colorbar(cfeature):
return pc.figure


@pytest.mark.mpl_image_compare(remove_text=True, tolerance=1.23)
@pytest.mark.mpl_image_compare(remove_text=True,
tolerance=1.389 if version_check('matplotlib<3.10') else 0.0012)
@needs_cartopy
def test_global():
"""Test that we can set global extent."""
Expand All @@ -824,7 +826,8 @@ def test_global():
return pc.figure


@pytest.mark.mpl_image_compare(remove_text=True)
@pytest.mark.mpl_image_compare(remove_text=True,
tolerance=5.101 if version_check('matplotlib<3.10') else 0.019)
@needs_cartopy
def test_latlon():
"""Test our handling of lat/lon information."""
Expand Down
Loading