-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String-related fixes and improvements. #977
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… contains tab characters; fixed all "Name property not found..." WPF errors
Download the artifacts for this pull request here: GUI:
CLI: |
Miepee
reviewed
Jun 15, 2022
|
The first screenshot is "Strings" list - it has 256 characters limit |
Ah, whoops. |
…bject()" can highlight "UndertaleString" and it does write errors to debug console; fixed some typos; addressed @Miepee comments
Miepee
reviewed
Jun 15, 2022
Miepee
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UndertaleString
name in the tab titles.UndertaleString
addition.UndertaleString
items.UndertaleString
tab title updates on string content change and properly shortens if it contains tab characters.UndertaleString
is displayed as "(empty string)".HighlightObject()
UndertaleString
highlighting - the asset list will scroll to just added string; errors are written to debug console ifsilent = true
.Content
of a newUndertaleString
is "string(index)".Closes #975, closes #976