Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String-related fixes and improvements. #977

Merged
merged 6 commits into from
Jun 16, 2022

Conversation

VladiStep
Copy link
Member

@VladiStep VladiStep commented Jun 14, 2022

Description

  1. Fixed missing UndertaleString name in the tab titles.
  2. Fixed crash on new UndertaleString addition.
  3. "Copy name to clipboard" feature now works with UndertaleString items.
  4. UndertaleString tab title updates on string content change and properly shortens if it contains tab characters.
  5. Fixed all the instances of "Name property not found on object of type ..." WPF binding warning.
  6. An empty UndertaleString is displayed as "(empty string)".
  7. Fixed HighlightObject() UndertaleString highlighting - the asset list will scroll to just added string; errors are written to debug console if silent = true.
  8. Fixed some typos.
  9. Content of a new UndertaleString is "string(index)".

Closes #975, closes #976

@github-actions
Copy link

github-actions bot commented Jun 14, 2022

@Miepee
Copy link
Contributor

Miepee commented Jun 15, 2022

@VladiStep
Copy link
Member Author

VladiStep commented Jun 15, 2022

The first screenshot is "Strings" list - it has 256 characters limit

@Miepee
Copy link
Contributor

Miepee commented Jun 15, 2022

Ah, whoops.

…bject()" can highlight "UndertaleString" and it does write errors to debug console; fixed some typos; addressed @Miepee comments
@Grossley Grossley merged commit d21ba69 into UnderminersTeam:master Jun 16, 2022
@VladiStep VladiStep deleted the stringTabTitleFix branch June 16, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy name to clipboard doesn't work with strings Impossible to add strings anymore via right click
3 participants