Patch the GPU problem and add new test #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The unit tests do not account for tests on GPUs, and the error is reproduced in the following [colab notebook](https://colab.research.google.com/drive/1W-l13I3Vg0EmOVZSMCJ5ikocYd27vdku?usp=sharing). One solution is that for making the inference, it should explicitly be moved over to the CPU (i.e., `self.y_val.detach().cpu().numpy()`) and also give the users which device they would like `BaseTrainer` class to be trained on. In addition to this, the following commits where added: - Add patch to fix device issue with MultivariateNormal in svgpy_model - Adjust the plotting module for svgpr - Add tests for base_trainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.y_val.detach().cpu().numpy()) and also give the users which device they would likeBaseTrainerclass to be trained on. In addition to this, the following commits where added: