Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup and update the code #78

Merged
merged 3 commits into from
Jun 8, 2021
Merged

cleanup and update the code #78

merged 3 commits into from
Jun 8, 2021

Conversation

pan93412
Copy link
Member

@pan93412 pan93412 commented Jun 8, 2021 •
edited
Loading

partial test: passed

@pan93412 pan93412 self-assigned this Jun 8, 2021
@pan93412 pan93412 requested a review from 1715173329 June 8, 2021 18:09
@pan93412 pan93412 added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 8, 2021
@pan93412 pan93412 force-pushed the refactor/cleanup branch from 8247cee to 656b775 Compare June 8, 2021 18:20
@pan93412 pan93412 force-pushed the refactor/cleanup branch from 656b775 to f5dbab9 Compare June 8, 2021 18:21
1715173329
1715173329 approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@1715173329 1715173329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pan93412
Copy link
Member Author

pan93412 commented Jun 8, 2021

LGTM.

dammit. Don't you sleep?

@pan93412 pan93412 merged commit c5ee4ec into enhanced Jun 8, 2021
@1715173329
Copy link
Member

1715173329 commented Jun 8, 2021 •
edited
Loading

dammit. Don't you sleep?

That's what actually I am about to do.
And then I got this from my E-mail...

Good night :-)

@pan93412 pan93412 deleted the refactor/cleanup branch June 9, 2021 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1715173329 1715173329 1715173329 approved these changes

Assignees

@pan93412 pan93412

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pan93412 @1715173329