Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!(Dockerfile): allow passing arguments to node #307

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

pan93412
Copy link
Member

@pan93412 pan93412 commented Nov 7, 2021

BREAKING CHANGES: No longer able to specify SOURCES with environment variable. Please read the new instruction in README.md.

This fixed #306.

BREAKING CHANGES: no longer able to specify SOURCES with environment variable. Please read the new instruction in README.md.
@pan93412 pan93412 added the enhancement New feature or request label Nov 7, 2021
@pan93412 pan93412 requested a review from 1715173329 November 7, 2021 09:17
@pan93412 pan93412 self-assigned this Nov 7, 2021
@pan93412 pan93412 merged commit 3f29900 into enhanced Nov 7, 2021
@pan93412 pan93412 deleted the feat/docker-argument branch November 7, 2021 09:21
Copy link
Member

@1715173329 1715173329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with it but LGTM - Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants