Add logic to verify the host key of a cloud server #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Computes the HMAC-SHA1 of some data, with the specified key. | ||
| * Both key and data are interpreted as "binary strings" so to supply binary | ||
| * data or key you can construct a string with the help of | ||
| * All function arguments are interpreted as "Binary strings" so to supply |
There was a problem hiding this comment.
"binary strings", e.g. as returned by Buffer.toString('binary')
|
I think this is good! It's what's happening in the frontend that worries me :-) |
This also updates our typing for crypto/sha1
jpevarnek
force-pushed
the
cloud-provider-verification
branch
from
3a48bc5 to
30c89e7
Compare
|
PTAL, thanks! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates our typing for crypto/sha1
I'm sorry...
This change is