Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delegate a bunch of arraybuffers functions to Buffer #391

Merged
merged 5 commits into from
Apr 15, 2016

Conversation

trevj
Copy link
Contributor

@trevj trevj commented Apr 15, 2016

Now that we can use the constructors that share memory, we can farm out a bunch of arraybuffers functions to Buffer. This is just one step...gradually getting better/saner (I think most of the mthods in arraybuffers should die, especially {decode|encode}{Byte|Short}.


This change is Reviewable

@trevj trevj force-pushed the trevj-arraybuffers-use-buffer-where-possible branch from 5bb0cb9 to 922cf18 Compare April 15, 2016 15:51
@jpevarnek
Copy link
Contributor

All the 👍s!!!!!!!!!!!!!


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@trevj trevj merged commit afce285 into master Apr 15, 2016
@trevj trevj deleted the trevj-arraybuffers-use-buffer-where-possible branch May 11, 2016 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants